Fix favorites #3138
Merged
Fix favorites #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Dec 22, 2023
lucasbordeau
commented
- Use new object record CRUD with favorites
- Fixed minor bugs in object record CRUD optimistic rendering
thaisguigon
suggested changes
Dec 27, 2023
packages/twenty-front/src/modules/object-metadata/utils/getObjectRecordIdentifier.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/sanitizeRecordInput.ts
Outdated
Show resolved
Hide resolved
|
The optimistic rendering is not working when adding a favorite. Enregistrement.de.l.ecran.2024-01-02.a.14.55.29.mov |
packages/twenty-front/src/modules/apollo/optimistic-effect/hooks/useOptimisticEffect.ts
Show resolved
Hide resolved
| const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState); | ||
|
|
||
| const [favorites, setFavorites] = useRecoilState(favoritesState); | ||
| const favoriteObjectNameSingular = 'favorite'; |
There was a problem hiding this comment.
I feel we could introduce an enum here for all standard objects
There was a problem hiding this comment.
I see that you already have one: StandardObjectNameSingular
There was a problem hiding this comment.
It's in another PR
packages/twenty-front/src/modules/favorites/hooks/useFavorites.ts
Outdated
Show resolved
Hide resolved
thaisguigon
reviewed
Jan 3, 2024
packages/twenty-front/src/modules/object-metadata/utils/isStandardObject.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.